-
-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix yiisoft/yii2#20202 #350
Conversation
lav45
commented
Jun 15, 2024
Q | A |
---|---|
Is bugfix? | ✔️ |
New feature? | ❌ |
Breaks BC? | ✔️ |
Fixed issues | yiisoft/yii2#20202 |
It will just install older version. It's better to fix the reason for such behavior. |
This reverts commit c533951.
@samdark I fixed the error, but the build still doesn't work. Also, we need to somehow reconcile the versions of yii2-elasticsearch and yii2, but I don't yet understand how. yii2:2.0.50 works with php>=7.4, while yii2-elasticsearch requires php>=5.6. |
@terabytesoftw merged. @lav45 can you resolve conflicts please? |
I can confirm that the latest https://github.com/terabytesoftw/yii2-elasticsearch/actions/runs/9546397753/job/26309179454 |
@terabytesoftw you mean this PR isn't needed? |
I'm saying that now the fix works with yiisoft/yii2#20206 |
@terabytesoftw seems elastic search doesn't build anymore :( |
@lav45 can you add a line for CHANGELOG? Thanks. |
Thank you! |