-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto fix outdated links in comments and documentation #19325
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks 👍
Still errors:
|
@samdark нет бы, помочь.. поправил. need filter test/dummy hosts in |
It takes forever to check all links but it seems it works. There are some issues though:
|
Judging on these, I'm not sure it's a good idea to add it to pipeline to automatically fix things. |
Permanent redirects codes: 301 and 308.
English manual must contains links to |
Ignores some redirects
@samdark partially fixed
at first, need collect links like as |
Add option `FixLinksController::$safeMode` Fix trimming in `findOutdatedLinks()`
@samdark add safe mode to collect links without changes in files |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #19325 +/- ##
=======================================
Coverage 48.02% 48.02%
=======================================
Files 445 445
Lines 43892 43892
=======================================
Hits 21080 21080
Misses 22812 22812 ☔ View full report in Codecov by Sentry. |
Adds
\yii\build\helpers\LinkChecker
to checking links (caches results)Adds
\yii\build\controller\FixLinksController
to finding links, replacing updated links and logging removed linksAdds Github workflow
cron-outdated-links.yml
runingFixLinksController
every day