Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the column value in batch insert for SQLite prior to 3.7.11 ver… #19937

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

inisic
Copy link

@inisic inisic commented Aug 24, 2023

…sion

Q A
Is bugfix? ✔️/❌
New feature?
Breaks BC?
Fixed issues

@what-the-diff
Copy link

what-the-diff bot commented Aug 24, 2023

PR Summary

  • Improved Error Handling in 'batchInsert' method
    A new condition was inserted into the batchInsert method within the file QueryBuilder.php. This addition primarily reduces the chances of encountering an error when a specific column does not exist within our dataset. This enhancement makes our method more robust and less likely to fail, smoothing out the overall operation of the system.

  • Implemented Correct Typecasting
    Following the successful checking of requirements, the value is then accurately typecasted using a dbTypecast function. This change enhances the data integrity by ensuring that the column values are stored in the correct format. This is a crucial step in maintaining our database's reliability, making our data dealings much more efficient and precise.

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4c0a00f) 48.91% compared to head (36ae6b0) 48.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #19937   +/-   ##
=======================================
  Coverage   48.91%   48.91%           
=======================================
  Files         445      445           
  Lines       42810    42810           
=======================================
  Hits        20941    20941           
  Misses      21869    21869           
Files Changed Coverage Δ
framework/db/sqlite/QueryBuilder.php 41.66% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samdark samdark added the pr:request for unit tests Unit tests are needed. label Aug 26, 2023
@samdark
Copy link
Member

samdark commented Aug 26, 2023

Would you please add tests and CHANGELOG for the change? It's currently not clear what does it fix. Tests would prevent it being broken again in the future.

@terabytesoftw
Copy link
Member

terabytesoftw commented Sep 21, 2023

Hi, any update on this PR. @inisic

Thks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:request for unit tests Unit tests are needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants