Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated methods to Query::class. #19966

Merged
merged 1 commit into from
Sep 30, 2023
Merged

Remove deprecated methods to Query::class. #19966

merged 1 commit into from
Sep 30, 2023

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

@what-the-diff
Copy link

what-the-diff bot commented Sep 22, 2023

PR Summary

  • Removal of getUniqueColumns Method
    This PR has eliminated the method getUniqueColumns in the Query.php file. This function was previously responsible for getting distinct columns from a specific query.

  • Removal of getUnaliasedColumnsFromSelect Method
    Likewise, the method getUnaliasedColumnsFromSelect has also been eliminated from the Query.php file. Its primary task was to fetch columns from the Select statement in the query without using any aliases.

While these removals may seem like a reduction in functionality, they are part of an overall improvement strategy to streamline the system's performance and simplify the code's complexity for ease of maintenance. This is carried out based on the usage analysis, determining that these methods were underutilized or had alternative ways of achieving the same result with existing methods.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.04% 🎉

Comparison is base (e7be9e9) 67.14% compared to head (fc21394) 67.18%.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.2   #19966      +/-   ##
============================================
+ Coverage     67.14%   67.18%   +0.04%     
+ Complexity    11226    11213      -13     
============================================
  Files           424      424              
  Lines         35650    35627      -23     
============================================
  Hits          23937    23937              
+ Misses        11713    11690      -23     
Files Changed Coverage Δ
framework/db/Query.php 94.57% <ø> (+6.12%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bizley bizley merged commit 169c5fb into yiisoft:2.2 Sep 30, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants