Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated methods to User::class. #19972

Merged
merged 1 commit into from
Sep 23, 2023
Merged

Remove deprecated methods to User::class. #19972

merged 1 commit into from
Sep 23, 2023

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

@what-the-diff
Copy link

what-the-diff bot commented Sep 22, 2023

PR Summary

  • Removal of Deprecated getAuthManager() method in User.php
    The older getAuthManager() method, which is due to be removed in an upcoming version (2.1), has been eliminated from the User.php file. Its functionality has become obsolete due to new changes.
  • Update to getAccessChecker() method in User.php
    The getAccessChecker() method has been updated to return the value of Yii::$app->getAuthManager() when the accessChecker property has no assigned value, effectively replacing the functionality of the now-removed getAuthManager() method. This adds stability and ensures the system doesn't experience failures due to lack of an assigned value.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +39.06% 🎉

Comparison is base (6618aa8) 28.12% compared to head (12591df) 67.18%.

Additional details and impacted files
@@              Coverage Diff              @@
##                2.2   #19972       +/-   ##
=============================================
+ Coverage     28.12%   67.18%   +39.06%     
+ Complexity    11209    11208        -1     
=============================================
  Files           424      424               
  Lines         35617    35615        -2     
=============================================
+ Hits          10016    23928    +13912     
+ Misses        25601    11687    -13914     
Files Changed Coverage Δ
framework/web/User.php 87.17% <100.00%> (+87.17%) ⬆️

... and 203 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bizley bizley merged commit ce68c7e into yiisoft:2.2 Sep 23, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants