Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method className(), don't break BC third party extensions. #19973

Merged
merged 1 commit into from
Sep 23, 2023
Merged

Add method className(), don't break BC third party extensions. #19973

merged 1 commit into from
Sep 23, 2023

Conversation

terabytesoftw
Copy link
Member

@terabytesoftw terabytesoftw commented Sep 22, 2023

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

View comment: #19894 (comment)

@what-the-diff
Copy link

what-the-diff bot commented Sep 22, 2023

PR Summary

  • Introduction of New Method in Base Class
    A fresh function named className() has been incorporated in our fundamental class file, BaseObject.php. It is tasked with providing the complete name of the class it's applied on.

  • New Test for the Base Class Method
    To ensure the new method's functionality and robustness, a test named testClassName() has been created in BaseObjectTest.php. This evaluates the performance of the className() function under various scenarios.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +39.06% 🎉

Comparison is base (6618aa8) 28.12% compared to head (726e641) 67.18%.

Additional details and impacted files
@@              Coverage Diff              @@
##                2.2   #19973       +/-   ##
=============================================
+ Coverage     28.12%   67.18%   +39.06%     
- Complexity    11209    11210        +1     
=============================================
  Files           424      424               
  Lines         35617    35619        +2     
=============================================
+ Hits          10016    23932    +13916     
+ Misses        25601    11687    -13914     
Files Changed Coverage Δ
framework/base/BaseObject.php 100.00% <100.00%> (+56.09%) ⬆️

... and 203 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bizley bizley merged commit 1cb372d into yiisoft:2.2 Sep 23, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants