Fix error summary always visible with CSP header (#19691) #20105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20105 +/- ##
==========================================
- Coverage 48.02% 47.56% -0.46%
==========================================
Files 445 445
Lines 43889 43410 -479
==========================================
- Hits 21077 20650 -427
+ Misses 22812 22760 -52 ☔ View full report in Codecov by Sentry. |
samdark
reviewed
Jan 18, 2024
Co-authored-by: Alexander Makarov <[email protected]>
Co-authored-by: Alexander Makarov <[email protected]>
samdark
approved these changes
Jan 18, 2024
bizley
approved these changes
Jan 18, 2024
Arhell
approved these changes
Jan 19, 2024
skepticspriggan
deleted the
19691-error-summary-always-visible-with-csp-header
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is fixed by allowing the user to specify a HTML class for an empty error summary. The CSS style corresponding to the class can be set locally in the user's project.