Remove unnecessary check in the AccessRule::matchRole()

[neoka4]

Q	A
Is bugfix?	✔️

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0027227) 48.02% compared to head (2794e25) 48.03%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #20106   +/-   ##
=======================================
  Coverage   48.02%   48.03%           
=======================================
  Files         445      445           
  Lines       43892    43890    -2     
=======================================
+ Hits        21080    21082    +2     
+ Misses      22812    22808    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bizley]

Which bug does it fix? What is the problem here?

[schmunk42]

From looking into the code, $roleParams is not set before, so this if() is always true.

[bizley]

I think it was added because it's in the foreach loop, so to not repeat the call for each item.

[bizley]

Closing it, since the current code looks ok. Feel free to write here if it needs to be reopen.