Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to PSR12 coding standard #20121

Merged
merged 11 commits into from
Mar 19, 2024

Refactor private vars with underscore

8620cbc
Select commit
Loading
Failed to load commit list.
Merged

Upgrade to PSR12 coding standard #20121

Refactor private vars with underscore
8620cbc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 18, 2024 in 0s

48.01% (-0.02%) compared to b0aa6ab, passed because coverage increased by +0.05% when compared to adjusted base (47.96%)

View this Pull Request on Codecov

48.01% (-0.02%) compared to b0aa6ab, passed because coverage increased by +0.05% when compared to adjusted base (47.96%)

Details

Codecov Report

Attention: Patch coverage is 63.75000% with 58 lines in your changes are missing coverage. Please review.

Project coverage is 48.01%. Comparing base (b0aa6ab) to head (8620cbc).

Files Patch % Lines
framework/helpers/BaseFormatConverter.php 2.77% 35 Missing ⚠️
framework/console/ErrorHandler.php 0.00% 4 Missing ⚠️
framework/db/pgsql/QueryBuilder.php 42.85% 4 Missing ⚠️
framework/behaviors/AttributesBehavior.php 50.00% 2 Missing ⚠️
framework/db/cubrid/Schema.php 0.00% 2 Missing ⚠️
framework/grid/DataColumn.php 60.00% 2 Missing ⚠️
framework/i18n/Formatter.php 50.00% 2 Missing ⚠️
framework/base/Security.php 50.00% 1 Missing ⚠️
framework/behaviors/AttributeBehavior.php 50.00% 1 Missing ⚠️
...ramework/console/controllers/MigrateController.php 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20121      +/-   ##
==========================================
- Coverage   48.02%   48.01%   -0.02%     
==========================================
  Files         445      445              
  Lines       43892    43909      +17     
==========================================
+ Hits        21080    21083       +3     
- Misses      22812    22826      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.