Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for PHP 8.4 branch master. #20132

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

Copy link

what-the-diff bot commented Mar 20, 2024

PR Summary

  • Support for PHP 8.4 Added
    The .github/workflows/build.yml and .github/workflows/ci-mssql.yml files have been updated to support PHP version 8.4. This upgrade will keep our system up-to-date with the latest version of PHP, improving performance and compatibility.

  • Updated PHP and MySQL Versions
    In the .github/workflows/ci-mysql.yml file, the PHP and MySQL versions have been updated. These adjustments enhance the stability and execution of our system interacting with My SQL database.

  • Updated PHP Version in Oracle Workflow
    The PHP version in the .github/workflows/ci-oracle.yml file has been upgraded. This provides enhanced support and efficency while interacting with Oracle based systems.

  • Updated PHP and PostgreSQL Version
    In the .github/workflows/ci-pgsql.yml file, the PHP and PostgreSQL versions have been updated. These tweaks provide in enhanced support for our applications using PostgreSQL databases.

  • Updated PHP Version in SQLite Workflow
    The PHP version in the .github/workflows/ci-sqlite.yml file has been upgraded. This ensures better performance and robustness for our SQLite intergrated systems.

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.48%. Comparing base (e2a1670) to head (93219df).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20132      +/-   ##
==========================================
- Coverage   48.01%   45.48%   -2.54%     
==========================================
  Files         445      445              
  Lines       43909    43909              
==========================================
- Hits        21083    19971    -1112     
- Misses      22826    23938    +1112     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@terabytesoftw
Copy link
Member Author

terabytesoftw commented Mar 20, 2024

Hi, with the new RFC of explicit nullable in PHP 8.4, the tests will fail, we must upload the PHP version in the master branch for 2.0.50, there is already work done around PHP 7.3, but i think we should increase to at least PHP 7.4 , this will allow us to eliminate cwgans patch and use PHPUnit 9.6.

@rob006
Copy link
Contributor

rob006 commented Mar 20, 2024

there is already work done around PHP 7.3, but i think we should increase to at least PHP 7.4 , this will allow us to eliminate cwgans patch and use PHPUnit 9.6.

phpunit 9.6 works on PHP 7.3

@rob006
Copy link
Contributor

rob006 commented Mar 20, 2024

There is also a PR with nullable types fix: #20133

@terabytesoftw Do you remember why #19959 was closed?

@terabytesoftw
Copy link
Member Author

There is also a PR with nullable types fix: #20133

@terabytesoftw Do you remember why #19959 was closed?

I closed it by mistake, but i have it locally, so i will upload it without problems, yes PHP 7.3 will also work with PHPUnit 9.6.

@terabytesoftw terabytesoftw added this to the 2.0.50 milestone Mar 21, 2024
@samdark samdark merged commit 28cbf6c into yiisoft:master Mar 22, 2024
53 of 79 checks passed
skepticspriggan pushed a commit to skepticspriggan/yii2 that referenced this pull request Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants