-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for PHP 8.4
branch master
.
#20132
Conversation
terabytesoftw
commented
Mar 20, 2024
Q | A |
---|---|
Is bugfix? | ❌ |
New feature? | ✔️ |
Breaks BC? | ❌ |
PR Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20132 +/- ##
==========================================
- Coverage 48.01% 45.48% -2.54%
==========================================
Files 445 445
Lines 43909 43909
==========================================
- Hits 21083 19971 -1112
- Misses 22826 23938 +1112 ☔ View full report in Codecov by Sentry. |
Hi, with the new RFC of explicit nullable in PHP 8.4, the tests will fail, we must upload the |
phpunit 9.6 works on PHP 7.3 |
There is also a PR with nullable types fix: #20133 @terabytesoftw Do you remember why #19959 was closed? |
I closed it by mistake, but i have it locally, so i will upload it without problems, yes |