-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bower is deprecated since 2017, we should use npm instead #20135
Conversation
https://bower.io/blog/2017/how-to-migrate-away-from-bower/ While at it, let's use minified JS in production. Credits @robregonm
PR Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.2 #20135 +/- ##
=========================================
Coverage 65.62% 65.62%
Complexity 11213 11213
=========================================
Files 424 424
Lines 36681 36681
=========================================
Hits 24073 24073
Misses 12608 12608 ☔ View full report in Codecov by Sentry. |
Related discussion in #14297 and yiisoft/yii2-bootstrap#221 I would argue that the cons presented by @schmunk42 there are not valid for core deps like Jquery. |
... or should we better switch to https://github.com/fxpio/foxy already? @francoispluchino what do you think? |
Yii2 is not using bower or even bower registry directly (packages are fetched from https://asset-packagist.org/ and installed by composer), so bower deprecation has not affect here. yiisoft/yii2-bootstrap#221 (comment) mentioned some clear disadvantages of using npm registry, what are the practical benefits of such change? |
Foxy would be cool, but it requires |
btw, i forked it and made some improvements, since fpachucino is busy https://github.com/php-forge/foxy |
@terabytesoftw asset-packagist works on it so if improvements are critical, it's worth contacting @hiqsol and @SilverFire so they update it there. |
@razvanphp is there anything that did not work for you? |
I totally understand, it's more of psychological change, so Yii2 is not using obsolete repositories in it's core code and also to discourage further use of bower. More than that, it can be that bower really stops being maintained and then even asset-packagist can't pull the metadata for the packages, right? |
I think @hiqsol and @SilverFire can comment on this one and the way forward if the shutdown of bower will indeed disrupt the service. |
Looking at the site it clears things up:
It seems, at least to me, that it works for both Bower and NPM. Which means as long as NPM is up, we have nothing to worry if Bower goes away! |
Moreover, if there is further doubt, it is better to log it on the repository at https://github.com/hiqdev/asset-packagist If you have no further objection, I will close this PR |
https://bower.io/blog/2017/how-to-migrate-away-from-bower/
https://www.yiiframework.com/wiki/785/use-minified-version-of-jqueryasset-bootstrapasset-and-all-default-assets - @robregonm