Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional parameter declared before required parameter is implicitly. #20139

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

Copy link

what-the-diff bot commented Mar 26, 2024

PR Summary

  • Enhancement of Parameter Handling in FakePhp71Controller.php
    The actionInjection method in the FakePhp71Controller.php file has been improved to effectively manage data types. Now, it clearly specifies what sort of data it expects and can also handle if no data ($post parameter) is provided.

  • Improved Flexibility in FakePhp71Controller.php
    The actionNullableInjection method within the FakePhp71Controller.php file also now accepts cases when the $request or $post parameters are missing. This widens the scenario where the function can be employed, offering more flexibility.

  • Security Feature Disabled in FakePhp71Controller.php
    A property named enableCsrfValidation in the FakePhp71Controller.php file has been set to 'false'. This turns off a security feature, which though can expedite request processing, it may also expose a vulnerability that needs to be checked properly before releasing.

  • Removal of Default Value in FakePhp7Controller.php
    The default value for the $bar parameter in actionAksi1 method of FakePhp7Controller.php has been removed. This enforces that the appropriate value needs to be always supplied, which may avoid the potential issue caused by relying on an assumed default value.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.82%. Comparing base (a292af1) to head (fd0b72a).

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #20139   +/-   ##
=========================================
  Coverage     64.82%   64.82%           
  Complexity    11376    11376           
=========================================
  Files           429      429           
  Lines         37074    37074           
=========================================
  Hits          24034    24034           
  Misses        13040    13040           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samdark samdark merged commit 923c309 into yiisoft:master Mar 26, 2024
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants