Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CallbackDependency #20158

Merged
merged 1 commit into from
May 16, 2024
Merged

Fix CallbackDependency #20158

merged 1 commit into from
May 16, 2024

Conversation

rob006
Copy link
Contributor

@rob006 rob006 commented May 15, 2024

Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ❌
Fixed issues

@schmunk42
Copy link
Contributor

schmunk42 commented May 15, 2024 •
edited
Loading

Why is the test green in the original commit and with your fix?

8861f7b#diff-57a96cab3e08c948305d1fb793933cfea989debf497119b97fd39b477a4706ad

@schmunk42
Copy link
Contributor

Sorry, forget it.

Just noticed that only unit tests (build) were failing https://github.com/yiisoft/yii2/actions/runs/8676707548

@samdark samdark added this to the 2.0.50 milestone May 15, 2024
@samdark
Copy link
Member

samdark commented May 15, 2024

Wow. Any idea when it was broken?

@samdark
Copy link
Member

samdark commented May 16, 2024

Do we need a CHANGELOG for this one?

@rob006
Copy link
Contributor Author

rob006 commented May 16, 2024

This bug was never released, since CallbackDependency was added in this state in #20137

@samdark samdark merged commit 391997a into yiisoft:master May 16, 2024
71 checks passed
@samdark
Copy link
Member

samdark commented May 16, 2024

Alright. Thank you!

@rob006 rob006 deleted the patch-1 branch May 16, 2024 09:30
@laxity7
Copy link
Contributor

laxity7 commented May 16, 2024

@samdark this one of the reason because i used return call_user_func($this->callback) in original commit in my PR #20137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bizley bizley bizley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.50
Development

Successfully merging this pull request may close these issues.
5 participants
@rob006 @schmunk42 @samdark @laxity7 @bizley