Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes CodeSniffer errors #20288

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Fixes CodeSniffer errors #20288

merged 1 commit into from
Dec 6, 2024

Conversation

Izumi-kun
Copy link
Contributor

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues
Run phpcs: framework/db/BaseActiveRecord.php#L1786
Expected 1 space after FUNCTION keyword; 0 found

Run phpcs: framework/db/mssql/Schema.php#L827
The closing brace for the class must go on the next line after the body

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.85%. Comparing base (1a54384) to head (0d7a3a9).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #20288   +/-   ##
=========================================
  Coverage     64.85%   64.85%           
  Complexity    11402    11402           
=========================================
  Files           430      430           
  Lines         37140    37140           
=========================================
  Hits          24086    24086           
  Misses        13054    13054           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schmunk42 schmunk42 self-requested a review December 5, 2024 09:55
@samdark samdark merged commit 80f2545 into yiisoft:master Dec 6, 2024
84 of 87 checks passed
@samdark
Copy link
Member

samdark commented Dec 6, 2024

Thanks.

@Izumi-kun Izumi-kun deleted the fix-cs branch December 6, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants