Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #20140: Fix compatibility with PHP 8.4: calling session_set_save_handler() #20289

Merged
merged 3 commits into from
Dec 6, 2024

Update CHANGELOG.md

6349d57
Select commit
Loading
Failed to load commit list.
Merged

Fix #20140: Fix compatibility with PHP 8.4: calling session_set_save_handler() #20289

Update CHANGELOG.md
6349d57
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 6, 2024 in 0s

64.85% (-0.01%) compared to 80f2545, passed because coverage increased by 0.01% when compared to adjusted base (64.83%)

View this Pull Request on Codecov

64.85% (-0.01%) compared to 80f2545, passed because coverage increased by 0.01% when compared to adjusted base (64.83%)

Details

Codecov Report

Attention: Patch coverage is 79.16667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 64.85%. Comparing base (80f2545) to head (6349d57).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
framework/web/SessionHandler.php 71.42% 4 Missing ⚠️
framework/web/Session.php 88.88% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #20289      +/-   ##
============================================
- Coverage     64.85%   64.85%   -0.01%     
- Complexity    11402    11409       +7     
============================================
  Files           430      431       +1     
  Lines         37140    37142       +2     
============================================
+ Hits          24086    24087       +1     
- Misses        13054    13055       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.