Fix #20292: Fix \yii\web\Session should not set cookie params, when useCookie is false
#20293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kies is false Upgrading from PHP 8.3.7 to 8.3.14 breaks yii\web\Session when used with useCookies = false. Error: Session cookies cannot be used when session.use_cookies is disabled.
cebe
force-pushed
the
cebe/fix-cookie-params
branch
from
436006d to
3cff986
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20293 +/- ##
=========================================
Coverage 64.85% 64.85%
- Complexity 11409 11410 +1
=========================================
Files 431 431
Lines 37142 37143 +1
=========================================
+ Hits 24087 24088 +1
Misses 13055 13055 ☔ View full report in Codecov by Sentry. |
bizley
approved these changes
Dec 6, 2024
samdark
approved these changes
Dec 7, 2024
samdark
changed the title
\yii\web\Session should not set cookie params, when useCookie is false
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #20292: yii\web\Session should not set cookie params, when useCookies is false
Upgrading from PHP 8.3.7 to 8.3.14 breaks yii\web\Session when used with useCookies = false.
Error: Session cookies cannot be used when session.use_cookies is disabled.