Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare MSSQL workflow for ubuntu-24.04 runner image #20298

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

Izumi-kun
Copy link
Contributor

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues actions/runner-images#10636

The ubuntu-24.04 runner image does not include the ODBC driver, so an additional step is required to install it.
ODBC Driver 18 introduces a breaking change: the default Encrypt setting is now set to yes. To address this, I added Encrypt=no to the connection settings.

Another way to fix the tests is to explicitly specify runs-on: ubuntu-22.04.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.83%. Comparing base (dd4efda) to head (87e926a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #20298      +/-   ##
============================================
+ Coverage     63.43%   64.83%   +1.40%     
  Complexity    11417    11417              
============================================
  Files           431      431              
  Lines         37155    37155              
============================================
+ Hits          23568    24090     +522     
+ Misses        13587    13065     -522     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Izumi-kun
Copy link
Contributor Author

Looks like the mssql-server:2017 image won't start. Sad.

@samdark
Copy link
Member

samdark commented Dec 11, 2024

There's working one in https://github.com/yiisoft/db

@samdark samdark merged commit 3cd8f19 into yiisoft:master Dec 11, 2024
87 checks passed
@samdark
Copy link
Member

samdark commented Dec 11, 2024

Thank you!

@Izumi-kun Izumi-kun deleted the ci-mssql-fix3 branch December 11, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants