enhancement: output typings for bin/utils.js #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmonad
reviewed
Jan 8, 2021
| @@ -58,5 +58,5 @@ | |||
| // "emitDecoratorMetadata": true, /* Enables experimental support for emitting type metadata for decorators. */ | |||
| // "maxNodeModuleJsDepth": 5 | |||
| }, | |||
| "include": ["./src/y-websocket.js"] | |||
| "include": ["./src/y-websocket.js", "./bin/utils.js"] | |||
There was a problem hiding this comment.
Right, that makes total sense!
But is it possible to keep outDir: "./dist"? Or did it lead to issues?
There was a problem hiding this comment.
I will look into that! (it must have caused some issue or else why did I make so many changes lol. Lemme see if I can figure out what the issue was)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sounds like their may be major improvements coming that obsolete this, but for the time being this is the tweaks I've made to get typings working for
import { setPersistence, setupWSConnection } from '@stoplight/y-websocket/bin/utils'. Dunno if they'd be of interest to you but figured I'd share them.Huly®: YJS-728