Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workfile template builder: Allow custom resolve_template_path #875

Merged

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Sep 6, 2024

Changelog Description

Allow custom resolve_template_path to be implemented by AYON addon integrations

Additional info

Related to Houdini workfile templates that allows extra path resolving using hou.text.expandString

Testing notes:

  1. Test together with Add support to run the workfile template builder on startup and simplify resolve houdini path ayon-houdini#74

@BigRoy BigRoy self-assigned this Sep 6, 2024
@ynbot ynbot added type: enhancement Improvement of existing functionality or minor addition size/XS labels Sep 6, 2024
@BigRoy BigRoy removed the size/XS label Sep 6, 2024
Copy link
Contributor

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works on my side.
Both Houdini variables and UNC paths works.

Here are my cases:

  • $JOBtemplates\my_houdini_template.hip
    >>> [  Found template at: '//storage/work/ayon_projects/Robo/Assets/Character/robococo/work/cfx\templates\my_houdini_template.hip'  ] 
    
  • \\storage\studio\templates\my_houdini_template.hip
    >>> [  Found template at: '\\storage\studio\templates\my_houdini_template.hip'  ]
    
  • //storage/studio/templates/my_houdini_template.hip
    >>> [  Found template at: '\\storage\studio\templates\my_houdini_template.hip'  ]
    

BigRoy added a commit to fabiaserra/ayon-houdini that referenced this pull request Sep 9, 2024
@iLLiCiTiT iLLiCiTiT merged commit 7653e09 into ynput:develop Sep 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants