Convert Flame creators to new publisher #33
Conversation
robin-ynput
added
type: enhancement
robin-ynput
force-pushed
the
10_creator_new_publisher
branch
from
005ed37
to
86f3c66
Compare
| default_variant = "Main" | ||
|
|
||
| def collect_instances(self): | ||
| @staticmethod | ||
| def _get_project_workfile_filepath(): |
There was a problem hiding this comment.
Shouldn't this be function somehwere in ayon_flame.api? (I have no context so maybe not)
There was a problem hiding this comment.
This hopefully will remain very specific to create_workfile so I think it's better here.
To provide more context, ideally we would have used the Flame WireTap SDK to handle this, but because of this issue: #34 , we had to go with a side-car json file implementation instead.
Co-authored-by: Jakub Trllo <[email protected]>
Co-authored-by: Jakub Trllo <[email protected]>
Co-authored-by: Jakub Trllo <[email protected]>
|
The PR looks solid to me. After a short testing session, I have the following notes:
|
| }) | ||
|
|
||
| # add reviewable source to plate if shot has it | ||
| if sub_instance_data.get("reviewTrack") != "< none >": |
There was a problem hiding this comment.
@robin-ynput please look here for inspiration of the reviewable source distribution https://github.com/ynput/ayon-hiero/blob/c6d73f470ed50a0f0b15d15e2c4517600de2db92/client/ayon_hiero/plugins/create/create_shot_clip.py#L241
There was a problem hiding this comment.
Thanks, as suggested I'll look into this as a separate PR.
| EnumDef( | ||
| "reviewTrack", | ||
| label="Use Review Track", | ||
| tooltip="Generate preview videos on fly, if " | ||
| "'< none >' is defined nothing will be generated.", | ||
| items=['< none >'] + gui_tracks, | ||
| ), |
There was a problem hiding this comment.
To make it aligned with Hiero here is also another difference https://github.com/ynput/ayon-hiero/blob/develop/client/ayon_hiero/plugins/create/create_shot_clip.py#L485-L489
Notice that the attribute is called reviewableSource for a reason. Please take a look at how the flow of the attribute is designed. It is then distributed to the publishing context and used here to determine whether we use review track or clip media for reviewable transcoding downstream. https://github.com/ynput/ayon-hiero/blob/develop/client/ayon_hiero/plugins/publish/collect_plates.py#L34-L47
This of course means that there will be lot of changes and perhaps it would be good to separate them into new PR which would be based on this PR and targeted back to it.
There was a problem hiding this comment.
Thanks, as suggested I'll look into this as a separate PR.
| if current_sequence is not None: | ||
| gui_tracks = get_video_track_names(current_sequence) | ||
| else: | ||
| gui_tracks = [] |
There was a problem hiding this comment.
Another distinque difference is that in Hiero we have moved from List[str] towards List[dict] so we are able to improve labeling for better user communication. Look here https://github.com/ynput/ayon-hiero/blob/develop/client/ayon_hiero/plugins/create/create_shot_clip.py#L211-L216
There was a problem hiding this comment.
Thanks, as suggested I'll look into this as a separate PR.
|
@jakubjezek001 I have started a draft PR aside for the review work: For the marker comment, I couldn't find any API to delete markers from within Flame hence the empty marker for now. |
Changelog Description
resolve #10
Make flame creators use the Creator API and new widget. Publishable products are now listed as individual instances following a similar logic than Hiero and Resolve.
Done:
colorspacedata following Update metadata keys and add colorspace data ayon-hiero#23Testing notes:
In Flame:
Tested locally on Flame 2024.2