Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update product type vdb to vdbcache name for icon #789

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Sep 9, 2024

Description of changes

I'm pretty sure that VDBs published from Houdini and Maya do not show the relevant vdb icon because the product type is vdbcache and not vdb. So this refactors the hardcoded icon to match vdbcache name.

I did not test this. :)

Technical details

Also see: ynput/ayon-traypublisher#13

Additional context

No idea whether changing this may affect anything else.

@BigRoy BigRoy added the type: bug Something isn't working label Sep 9, 2024
@BigRoy BigRoy requested a review from Innders September 9, 2024 14:56
@BigRoy BigRoy self-assigned this Sep 9, 2024
@BigRoy BigRoy changed the title Update vdb to vdbcache Update product type vdb to vdbcache name for icon Sep 9, 2024
@BigRoy
Copy link
Contributor Author

BigRoy commented Sep 9, 2024

vdb_icon

Here's an example of the issue actually.

The maya and houdini publishers (and loaders) use vdbcache which currently do not display in the frontend with an icon. With ynput/ayon-traypublisher#13 the traypublisher would also publsh it as vdbcache so that the product type is the same everywhere - making this new icon name the right default.

Meaning that in this example above, where vdbMain and vdbTest (considered to be the wrong product type vdb) would then display the default box icon but vdbcacheMain would display the fire.

🔥

Copy link
Member

@Innders Innders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say I have ever seen the "local fire department" icon anywhere so far so probably safe to change.

If someone complains we can add it back.

Thanks @BigRoy 😊

@Innders Innders merged commit 3791323 into ynput:develop Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants