Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync: Folder and Task statuses #147

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

First implementation of statuses sync for task and folder entities.

Additional info

Because we don't sync statuses from ftrack to AYON we skip all status changes when the status is not available in AYON.

This PR requires ayon-python-api PR ynput/ayon-python-api#188 so can't be tested right now.

Testing notes:

  1. Run services.
  2. Sync a project, statuses from ftrack should be synced to AYON.
  3. Change statuse on project with auto-sync, the change should be synced to AYON if status is available.

@iLLiCiTiT iLLiCiTiT self-assigned this Oct 16, 2024
@iLLiCiTiT iLLiCiTiT added the type: enhancement Improvement of existing functionality or minor addition label Oct 16, 2024
@64qam
Copy link
Member

64qam commented Oct 16, 2024

Not working now, returns error after status change in Ftrack

2024-10-16 10:32:06 WARNING  An error has happened during synchronization
Traceback (most recent call last):
  File "C:\Users\qam\code\ayon-ftrack\services\processor\processor\default_handlers\event_sync_from_ftrack.py", line 1614, in process_event_data
    self._propagate_attrib_changes()
  File "C:\Users\qam\code\ayon-ftrack\services\processor\processor\default_handlers\event_sync_from_ftrack.py", line 1444, in _propagate_attrib_changes
    self._propagate_status_changes(status_changes)
  File "C:\Users\qam\code\ayon-ftrack\services\processor\processor\default_handlers\event_sync_from_ftrack.py", line 1338, in _propagate_status_changes
    if entity.status.lower() == new_status_name.lower():
AttributeError: 'TaskEntity' object has no attribute 'status'```

@iLLiCiTiT
Copy link
Member Author

Not working now, returns error after status change in Ftrack

Forgot to bump ayon api version. Please try again. Make sure to create new image when testing with docker, and make sure to run ./service_tools/manage.ps1 install if testing with service tools.

@iLLiCiTiT iLLiCiTiT changed the title Ftrack sync: Folder and Task statuses Sync: Folder and Task statuses Oct 16, 2024
Copy link
Member

@64qam 64qam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@iLLiCiTiT iLLiCiTiT merged commit b013fc4 into develop Oct 16, 2024
1 check passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/125-ay-6234_sync-statuses branch October 16, 2024 09:41
@mkolar mkolar linked an issue Nov 4, 2024 that may be closed by this pull request
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AY-6234_Ftrack: attributes need to be synced from Ftrack to Ayon
2 participants