Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group USD Explict Save Layer Products to "USD Layer" product group #146

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Oct 27, 2024

Changelog Description

USD Explicit Save Layer products should go into the USD Layer product group similar to how USD contribution workflow does that.

Additional info

Fixes #129

For context on "Explicit Layer Save Paths" see:

Testing notes:

  1. Create a USD publish with Explicit Save Layers that will turn into dependent products of their own.
  2. Those newly created products should now by default go into a "USD Layer" product group.
  3. This should work both with USD contribution workflow enabled AND disabled.

…ct group similar to how USD contribution workflow does that.
@BigRoy BigRoy added type: bug Something isn't working sponsored This is directly sponsored by a client or community member labels Oct 27, 2024
@BigRoy BigRoy self-assigned this Oct 27, 2024
@Lypsolon
Copy link

fun fun fun.
not sure if i did it right but the pinning file json is faialing for me.


DEBUG: No staging directory on instance found.
ERROR: No staging directory found.
Traceback (most recent call last):
  File "/home/ynput/Documents/GitHub/Lyonh/AyonDev/repos/ayon-usd/client/ayon_usd/plugins/publish/extract_skeleton_pinning_json.py", line 58, in process
    staging_dir = Path(instance.data["stagingDir"])
KeyError: 'stagingDir'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/ynput/Documents/GitHub/Lyonh/AyonDev/repos/ayon-usd/client/ayon_usd/plugins/publish/extract_skeleton_pinning_json.py", line 62, in process
    staging_dir = Path(instance.data["ifdFile"]).parent
KeyError: 'ifdFile'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/ynput/.local/share/AYON/dependency_packages/ayon_2406251627_linux-rocky9.zip/dependencies/pyblish/plugin.py", line 528, in __explicit_process
    runner(*args)
  File "/home/ynput/Documents/GitHub/Lyonh/AyonDev/repos/ayon-usd/client/ayon_usd/plugins/publish/extract_skeleton_pinning_json.py", line 65, in process
    raise KnownPublishError("Cannot determine staging directory.") from e
ayon_core.pipeline.publish.publish_plugins.KnownPublishError: Cannot determine staging directory.

image
image
image

@BigRoy
Copy link
Contributor Author

BigRoy commented Oct 28, 2024

Thanks @Lypsolon - yes, that's a bug in ayon-usd.

See: ynput/ayon-usd#75

So in this case you may be better of testing without ayon-usd in your bundle.

Copy link

@Lypsolon Lypsolon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice this works.

image

@BigRoy BigRoy merged commit 366268c into ynput:develop Oct 29, 2024
1 check passed
@BigRoy BigRoy deleted the enhancement/usd_explicit_layer_save_products_to_usd_layer_group branch October 29, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sponsored This is directly sponsored by a client or community member type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AY-6980_USD Publish Explicit Save Layers products should go into "USD Layer" product group
2 participants