Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Require newer ayon core #4

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Jul 3, 2024

Description

After PR ynput/ayon-core#295 the addon require ayon-core > 0.4.0 .

Additional information

This should be already part of that PR and ayon-houdini release 0.3.9 .

@iLLiCiTiT iLLiCiTiT requested a review from BigRoy July 3, 2024 08:19
Copy link
Contributor

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description and change makes sense - I'm not sure how to confirm the compatibility check itself actually works but I suppose that's an existing feature that we know should work?

@iLLiCiTiT
Copy link
Member Author

Description and change makes sense - I'm not sure how to confirm the compatibility check itself actually works but I suppose that's an existing feature that we know should work?

Happens on bundle creation on AYON server.

@BigRoy
Copy link
Contributor

BigRoy commented Jul 3, 2024

So I tested this out and it does work:

image
image
image

However, the PR description makes it sound like anything ABOVE 0.3.9 should be fine - but the compatibility check only allows above 0.4.0 and does not allow exactly 0.4.0. Is that correct?

@BigRoy BigRoy assigned iLLiCiTiT and unassigned BigRoy Jul 3, 2024
@iLLiCiTiT
Copy link
Member Author

iLLiCiTiT commented Jul 3, 2024

but the compatibility check only allows above 0.4.0 and does not allow exactly 0.4.0. Is that correct?

It should allow greater than 0.4.0 . Core release 0.4.0 does not contain changes that current houdini develop requires. The changes are in current develop of core addon.

If you mean 0.3.9 release, I meant 0.3.9 release of ayon-houdini (modified description ot make it clear).

@BigRoy
Copy link
Contributor

BigRoy commented Jul 3, 2024

In that case, PR looks good 👍

@iLLiCiTiT iLLiCiTiT merged commit b2ceb5e into develop Jul 3, 2024
1 check passed
@iLLiCiTiT iLLiCiTiT deleted the bugfix/require-newer-ayon-core branch July 3, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants