Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated ocio_config ImageIOConfigModel settings #47

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Jul 17, 2024

Changelog Description

Remove deprecated ocio_config ImageIOConfigModel settings

Additional info

With the support of profiles to determine OCIO config in ayon-core this logic has been superseded and should be removed from each addon still having the deprecated settings.

Fixes #46

@BigRoy BigRoy requested review from iLLiCiTiT and MustafaJafar July 17, 2024 18:47
@BigRoy BigRoy self-assigned this Jul 17, 2024
@BigRoy BigRoy marked this pull request as ready for review July 18, 2024 10:14
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

Copy link
Contributor

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works on my side. Thanks.

Question (mostly irrelevant to this PR)
Should this renamed to Enable Global Color Management ?
image

@BigRoy
Copy link
Contributor Author

BigRoy commented Jul 18, 2024

It works on my side. Thanks.

Question (mostly irrelevant to this PR) Should this renamed to Enable Global Color Management ? image

If that screenshot is for the setting on ayon-core addon, then yes - that may be nice for clarity!
If it's for Ayon-houdini, then no.

@BigRoy BigRoy merged commit 4f4bbe8 into ynput:develop Jul 18, 2024
1 check passed
@BigRoy BigRoy deleted the chore/remove_deprecated_imageioconfig branch July 18, 2024 17:57
@MustafaJafar
Copy link
Contributor

If that screenshot is for the setting on ayon-core addon

It's from ayon-core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated ImageIOConfigModel from settings
3 participants