Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Use 'exist_ok' when directory is created #143

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Chore: Use 'exist_ok' when directory is created #143

merged 1 commit into from
Aug 6, 2024

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Use exist_ok=True when os.makedirs is called.

Additional info

Simplifies the code and also makes it more safe.

Testing notes:

  1. AYON launcher is capable of creating all folders that are necessary to be created.

BigRoy
BigRoy approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@iLLiCiTiT iLLiCiTiT merged commit 17f435e into develop Aug 6, 2024
1 check passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/use-exist-ok-on-dir-creation branch August 6, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigRoy BigRoy BigRoy approved these changes

@antirotor antirotor Awaiting requested review from antirotor

Assignees

@antirotor antirotor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iLLiCiTiT @BigRoy @antirotor