Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheme handler: Windows scheme handler does not need admin privileges #177

Merged

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Oct 10, 2024

Changelog Description

Register scheme handler under CURRENT_USER registry to avoid requirement for admin privileges and to avoid issues connected to multi-user machine.

Additional info

Modification of HKEY_CURRENT_USER\SOFTWARE\Classes does not require admin privileges and adding ayon-launcher there has same effect as in HKEY_CLASSES_ROOT.
User classes have bigger priority over HKEY_CLASSES_ROOT so it should work even if machine already has set up ayon-launcher in HKEY_CLASSES_ROOT.

Testing notes:

  1. Open regedit tool (Win + R -> type "regedit" -> Enter) and remove ayon-launcher from HKEY_CLASSES_ROOT (ignore this step if is not there).
  2. Build and make installer from this branch.
  3. Upload and install the installer on your machine.
  4. Start webaction (e.g. application) from AYON server.
  5. Application should be starting.

I don't know if we use AYON launcher as windows service anywhere, but I don't know what happens if windows service tries to access HKEY_CURRENT_USER as it is not running "under user".

Resolves #171

@iLLiCiTiT iLLiCiTiT self-assigned this Oct 10, 2024
@iLLiCiTiT iLLiCiTiT added the type: enhancement Improvement of existing functionality or minor addition label Oct 10, 2024
@64qam 64qam requested a review from MilaKudr October 11, 2024 07:27
@iLLiCiTiT iLLiCiTiT merged commit 0e6b7f1 into develop Oct 11, 2024
1 check passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/171-scheme-registration-avoid-admin-privileges branch October 11, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scheme registration: Avoid admin privileges
2 participants