Scheme handler: Windows scheme handler does not need admin privileges #177
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Register scheme handler under CURRENT_USER registry to avoid requirement for admin privileges and to avoid issues connected to multi-user machine.
Additional info
Modification of
HKEY_CURRENT_USER\SOFTWARE\Classes
does not require admin privileges and addingayon-launcher
there has same effect as inHKEY_CLASSES_ROOT
.User classes have bigger priority over
HKEY_CLASSES_ROOT
so it should work even if machine already has set upayon-launcher
inHKEY_CLASSES_ROOT
.Testing notes:
regedit
tool (Win + R -> type "regedit" -> Enter) and removeayon-launcher
fromHKEY_CLASSES_ROOT
(ignore this step if is not there).I don't know if we use AYON launcher as windows service anywhere, but I don't know what happens if windows service tries to access
HKEY_CURRENT_USER
as it is not running "under user".Resolves #171