generated from ynput/ayon-addon-template
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Update to new repository structure #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iLLiCiTiT
added
type: enhancement
Improvement of existing functionality or minor addition
bump minor
labels
Oct 10, 2024
iLLiCiTiT
changed the title
Chore: Update to new structure
Chore: Update to new repository structure
Oct 10, 2024
@tanh any chance you can review/test this PR? |
BigRoy
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merging this because it definitely fixes incompatibilities that should need fixing anyway. I can't test it due to no Syncsketch Enterprise access, but even if it's still broken - it would be similarly broken as it would be now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Create newest strucure of addon with package.py . Update create package to new variant, added auto-update of service version. Added ruff linter and fixed lines accordingly. Removed pyproject.toml from client code.
Additional info
I'm not sure why pyproject.toml in clinet had those dependencies, but seems to be unused. And because those dependencies should not be installed to generic dependencies but to runtime dependencies (if were needed) I've removed them. Le me know if that breaks something. It looks like they are meant for testing, but in that case they should not be in client pyproject.toml .
Testing notes: