Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update to new repository structure #8

Merged
merged 11 commits into from
Oct 14, 2024

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Oct 10, 2024

Changelog Description

Create newest strucure of addon with package.py . Update create package to new variant, added auto-update of service version. Added ruff linter and fixed lines accordingly. Removed pyproject.toml from client code.

Additional info

I'm not sure why pyproject.toml in clinet had those dependencies, but seems to be unused. And because those dependencies should not be installed to generic dependencies but to runtime dependencies (if were needed) I've removed them. Le me know if that breaks something. It looks like they are meant for testing, but in that case they should not be in client pyproject.toml .

Testing notes:

  1. Addon should work the same way or better than before.

@iLLiCiTiT iLLiCiTiT self-assigned this Oct 10, 2024
@iLLiCiTiT iLLiCiTiT added type: enhancement Improvement of existing functionality or minor addition bump minor labels Oct 10, 2024
@iLLiCiTiT iLLiCiTiT requested a review from 64qam October 10, 2024 15:36
@iLLiCiTiT iLLiCiTiT changed the title Chore: Update to new structure Chore: Update to new repository structure Oct 10, 2024
@BigRoy
Copy link
Contributor

BigRoy commented Oct 10, 2024

@tanh any chance you can review/test this PR?

Copy link
Contributor

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BigRoy
Copy link
Contributor

BigRoy commented Oct 14, 2024

Merging this because it definitely fixes incompatibilities that should need fixing anyway. I can't test it due to no Syncsketch Enterprise access, but even if it's still broken - it would be similarly broken as it would be now.

@BigRoy BigRoy merged commit 5f6a8f2 into develop Oct 14, 2024
1 check passed
@BigRoy BigRoy deleted the feature/update-to-new-structure branch October 14, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump minor type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants