Re #39 - Ignore External Tables #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for ignoring TVFs
dahlbyk
reviewed
Oct 31, 2023
Comment on lines
+246
to
+247
| and obj.type <> 'TF' /* Ignore table value functions */ | ||
| and not exists ( select * from sys.external_tables as et where et.object_id = obj.object_id ) |
There was a problem hiding this comment.
If the docs can be trusted it looks like external tables should have type = 'ET'?
Suggested change
| and obj.type <> 'TF' /* Ignore table value functions */ | |
| and not exists ( select * from sys.external_tables as et where et.object_id = obj.object_id ) | |
| and obj.type not in ('ET'/*external table*/, 'TF'/*table-valued function*/) |
There was a problem hiding this comment.
The docs cannot be trusted. That was my first approach.
There was a problem hiding this comment.
select
obj.[name],
obj.[type],
obj.[type_desc]
from
[sys].[external_tables] as et
inner join
[sys].[objects] as obj
on
obj.[object_id] = et.[object_id]
go
| name | type | type_desc |
|---|---|---|
| v_matter | U | USER_TABLE |
| v_client | U | USER_TABLE |
| v_e_superc | U | USER_TABLE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anti-Semi-Join against sys.external_tables on matching object_id to exclude External Tables
Also fix for ignoring TVFs - the [type] column is a 1 or 2 letter code, 'TF' for Table Valued Functions, whereas the [type_desc] is a brief description, 'SQL_TABLE_VALUED_FUNCTION' for Table Valued Functions.