Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

インポート時にライセンス欄にインポート元を追記する #573

Merged
merged 4 commits into from
Dec 26, 2024

Conversation

kozakura913
Copy link
Collaborator

@kozakura913 kozakura913 commented Dec 18, 2024

What

resolve: #491

Why

どこからインポートしたかわかるように

Additional info (optional)

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

@kozakura913 kozakura913 added this to the 1.3.0 milestone Dec 18, 2024
@kozakura913 kozakura913 self-assigned this Dec 18, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 19.87%. Comparing base (29bd161) to head (815c927).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/scripts/import-emoji.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #573       +/-   ##
============================================
- Coverage    59.92%   19.87%   -40.05%     
============================================
  Files          895      797       -98     
  Lines       106641   123110    +16469     
  Branches      2833     1041     -1792     
============================================
- Hits         63908    24474    -39434     
- Misses       42673    98031    +55358     
- Partials        60      605      +545     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@penginn-net
Copy link
Collaborator

バックエンドでやりたさはある(ダイアログ不安定だし)

@kozakura913
Copy link
Collaborator Author

バックエンドでやるならDB弄る感じになって別物になりそうな予感。
#544 でやった方が良さそう

@penginn-net
Copy link
Collaborator

ライセンス欄ならインポートする時に付加えるだけだしDB操作はあんまり変わらないとは思う

544とは別件かもあれはタグとかライセンスの連合であってインポート元書くじゃないし

@kozakura913
Copy link
Collaborator Author

インポート元カラム追加するイメージだった

@penginn-net
Copy link
Collaborator

しっかりやるならカラム追加よね

@kozakura913
Copy link
Collaborator Author

カテゴリ、タグ、ライセンスの取得自体割と簡易的な機能だし本格的な調整は544の後でやりたい

@penginn-net
Copy link
Collaborator

それで良いと思う

@kozakura913 kozakura913 merged commit db1709a into yojo-art:develop Dec 26, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

絵文字インポート時にインポート元の情報をメモる
2 participants