Fix playwright (#1727)

fix playwright
yomidevs · Jan 1, 2025 · 2cff992 · 2cff992
1 parent c80b4d5
commit 2cff992
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/.github/workflows/playwright.yml b/.github/workflows/playwright.yml
@@ -91,20 +91,17 @@ jobs:
 
       - name: "[PR] Store steps.master-screenshots.outcome in a file"
         run: echo ${{ steps.master-screenshots.outcome }} > ./master-screenshots-outcome
-        if: github.event_name == 'pull_request'
 
       - uses: actions/upload-artifact@v4
         with:
           name: master-screenshots-outcome-${{ matrix.shardIndex }}
           path: master-screenshots-outcome
-        if: github.event_name == 'pull_request'
 
       - uses: actions/upload-artifact@v4
         with:
           name: playwright-output-${{ matrix.shardIndex }}
           path: playwright-output
           retention-days: 1
-        if: github.event_name == 'pull_request'
 
   playwright:
     timeout-minutes: 60

diff --git a/.github/workflows/playwright_comment.yml b/.github/workflows/playwright_comment.yml
@@ -36,6 +36,14 @@ jobs:
           run_id: ${{ github.event.workflow_run.id }}
           name: master-screenshots-outcome
 
+      - name: Grab playwright-results-json from PR run
+        uses: dawidd6/action-download-artifact@80620a5d27ce0ae443b965134db88467fc607b43 # v7
+        continue-on-error: true
+        with:
+          github_token: ${{ secrets.GITHUB_TOKEN }}
+          run_id: ${{ github.event.workflow_run.id }}
+          name: playwright-results-json
+
       - name: Dry-run grab playwright-report from PR run so we have its ID
         uses: dawidd6/action-download-artifact@80620a5d27ce0ae443b965134db88467fc607b43 # v7
         id: playwright-report