Allow Hiding Skill's Percentage

[LaQuay]

This gives the possibility to the developer of deciding if the % is shown or not.

[yousinix]

Instead of adding another showPercentage key, I would recommend using the existing percentage key by hiding the percentage number when this key is not defined or empty. This approach is not just cleaner, but it prevents breaking existing sites.

Example:

- name: Skill X
  percentage: 90
  color: danger
  
# Percentage won't show
- name: Skill Y
  color: danger
 
# Percentage won't show
- name: Skill Z
  percentage: 
  color: danger

[LaQuay]

Hi, thanks for your fast response.
Maybe I did not explain it very well. The idea of this PR is to let the user have the possibility of having the bar with a percentage but hiding the percentage label.

If your concern is more about preventing breaking the existing sites, I could just add a check in the new if, checking if the attr exists.

[yousinix]

My bad, didn't understand it that way.
For the other approach you are proposing, I think it would be better if the showPercentage is a site-level configuration in _config.yml for consistency.

[LaQuay]

Hi, sorry for the late reply. I did not get the notification.

With your proposal, you cannot decide whether you want for some and not for others. There are different sections and with the solution, I propose you can do several things. With your proposal, it is either YES or NO.

[yousinix]

I don't understand why we might need to hide the percentage label for some skills and not for others. This behavior seems inconsistent.

[sakgoyal]

you can instead just do something like {% unless hidePercentage == true %} so it doesnt break existing pages right? this way it will only hide if the variable is defined and set to true. if its not defined, nothing will change.

Edit: like this here.