Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add holiday extensions to F1155, F1255 #178

Merged
merged 3 commits into from
Oct 13, 2024
Merged

Conversation

elupus
Copy link
Collaborator

@elupus elupus commented Oct 12, 2024

Fixes #175
Related to #174

Verified that the field value of 10 is invalid on F1155, so it likely is the same problem on the F750.

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 58.55%. Comparing base (5c1eba7) to head (c09fb08).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
nibe/console_scripts/convert_csv.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
+ Coverage   57.84%   58.55%   +0.70%     
==========================================
  Files          14       14              
  Lines        1274     1291      +17     
==========================================
+ Hits          737      756      +19     
+ Misses        537      535       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elupus
Copy link
Collaborator Author

elupus commented Oct 12, 2024

What do you think, should we just add this to all F-series?

nibe/data/f1155_f1255.json Outdated Show resolved Hide resolved
nibe/data/f750.json Outdated Show resolved Hide resolved
@elupus elupus marked this pull request as draft October 13, 2024 07:53
@elupus elupus marked this pull request as ready for review October 13, 2024 08:56
try:
d.pop(k)
except (IndexError, KeyError):
pass
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out the d object is a pandas object here and not a dict. pop there does not take a default argument. I think we don't recursively flatten the pandas object to a nested dict.

@yozik04 yozik04 merged commit a596a57 into yozik04:master Oct 13, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional undocumented registers for F1255
2 participants