-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add holiday extensions to F1155, F1255 #178
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #178 +/- ##
==========================================
+ Coverage 57.84% 58.55% +0.70%
==========================================
Files 14 14
Lines 1274 1291 +17
==========================================
+ Hits 737 756 +19
+ Misses 537 535 -2 ☔ View full report in Codecov by Sentry. |
What do you think, should we just add this to all F-series? |
try: | ||
d.pop(k) | ||
except (IndexError, KeyError): | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out the d object is a pandas object here and not a dict. pop there does not take a default argument. I think we don't recursively flatten the pandas object to a nested dict.
Fixes #175
Related to #174
Verified that the field value of 10 is invalid on F1155, so it likely is the same problem on the F750.