Support reception of non response payloads #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the gateway unit sends along all data instead of only response payloads, we need to understand the full payload sequence.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #188 +/- ##
==========================================
+ Coverage 69.88% 70.13% +0.25%
==========================================
Files 14 14
Lines 1348 1356 +8
==========================================
+ Hits 942 951 +9
+ Misses 406 405 -1 ☔ View full report in Codecov by Sentry. |
|
Need to add a testcase |
yozik04
reviewed
Nov 11, 2024
| if block.start_byte == "RESPONSE": | ||
| self._on_response(block, addr) | ||
| else: | ||
| logger.debug(block) |
There was a problem hiding this comment.
Let's add some prefix here of what is being logged. Otherwise, it is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the gateway unit sends along all data instead of only response payloads, we need to understand the full payload sequence.
This allow us to forward all pump data to the udp port instead of just the response payload for modbus40.