feat: remove invalid creator canisters and update controller (#478)

src/canister/individual_user_template/src/api/cdao/delete_all_sns_creator_token.rs

@@ -1,45 +1,48 @@
-use ic_cdk::api::management_canister::main::{deposit_cycles, CanisterIdRecord};
+use candid::Principal;
+use ic_cdk::{
+    api::management_canister::main::{
+        deposit_cycles, update_settings, CanisterIdRecord, CanisterSettings, UpdateSettingsArgument,
+    },
+    id,
+};
 use ic_cdk_macros::update;
 use shared_utils::{
     canister_specific::individual_user_template::types::{
         cdao::DeployedCdaoCanisters, session::SessionType,
     },
     common::utils::permissions::is_caller_controller,
+    constant::GLOBAL_SUPER_ADMIN_USER_ID,
+    types::sns_canisters::swap::{self, GetLifecycleArg, Swap},
 };
 
 use crate::CANISTER_DATA;
 
 use super::{
     request_cycles_from_subnet_orchestrator,
-    utils::uninstall_code_and_return_empty_canisters_to_subnet_backup_pool, SubnetOrchestrator,
+    utils::uninstall_code_and_return_empty_canisters_to_subnet_backup_pool,
 };
 
 #[update(guard = "is_caller_controller")]
 pub fn delete_all_creator_token() {
-    let session_type_opt = CANISTER_DATA.with_borrow(|canister_data| canister_data.session_type);
-
-    if let Some(session_type) = session_type_opt {
-        if matches!(session_type, SessionType::RegisteredSession) {
-            return;
-        }
-    }
-
     let deployed_canisters =
         CANISTER_DATA.with_borrow(|canister_data| canister_data.cdao_canisters.clone());
 
     deployed_canisters
-        .iter()
+        .into_iter()
         .for_each(|deployed_cdao_canisters| {
-            delete_sns_creator_token(deployed_cdao_canisters);
+            update_or_delete_sns_creator_token(deployed_cdao_canisters);
         });
-
-    CANISTER_DATA.with_borrow_mut(|canister_data| {
-        canister_data.cdao_canisters = vec![];
-    })
 }
 
-pub fn delete_sns_creator_token(deployed_canisters: &DeployedCdaoCanisters) {
+pub fn update_or_delete_sns_creator_token(deployed_canisters: DeployedCdaoCanisters) {
     let canister_ids = deployed_canisters.get_canister_ids();
+    let anonymous_session = CANISTER_DATA
+        .with_borrow(|canister_data| {
+            canister_data
+                .session_type
+                .map(|session| session == SessionType::AnonymousSession)
+        })
+        .unwrap_or(false);
 
     const UNINSTALL_RECHARGE_AMOUNT: u128 = 300_000_000_000;
 
@@ -54,6 +57,72 @@ pub fn delete_sns_creator_token(deployed_canisters: &DeployedCdaoCanisters) {
             )
             .await;
         }
-        uninstall_code_and_return_empty_canisters_to_subnet_backup_pool(canister_ids).await;
+
+        let needs_to_be_deleted =
+            anonymous_session || is_sns_canister_in_invalid_state(deployed_canisters.swap).await;
+
+        if needs_to_be_deleted {
+            uninstall_code_and_return_empty_canisters_to_subnet_backup_pool(canister_ids).await;
+            CANISTER_DATA.with_borrow_mut(|canister_data| {
+                canister_data
+                    .cdao_canisters
+                    .retain(|key| *key != deployed_canisters);
+            });
+
+            ic_cdk::println!(
+                "Deleting creator SNS canisters with Root Canister Id {}",
+                deployed_canisters.root.to_text()
+            )
+        } else {
+            update_controllers_for_ledger_and_swap(deployed_canisters).await
+        }
     });
 }
+
+pub async fn is_sns_canister_in_invalid_state(swap_canister_id: Principal) -> bool {
+    let swap_canister = swap::Service(swap_canister_id);
+
+    let swap_lifecycle_res = swap_canister.get_lifecycle(GetLifecycleArg {}).await;
+
+    match swap_lifecycle_res {
+        Ok((lifecycle,)) => {
+            if let Some(lifecycle) = lifecycle.lifecycle {
+                lifecycle == 4
+            } else {
+                false
+            }
+        }
+        Err(_e) => false,
+    }
+}
+
+pub async fn update_controllers_for_ledger_and_swap(deployed_canister: DeployedCdaoCanisters) {
+    let global_super_admin_principal = Principal::from_text(GLOBAL_SUPER_ADMIN_USER_ID).unwrap();
+
+    let _ = update_settings(UpdateSettingsArgument {
+        canister_id: deployed_canister.ledger,
+        settings: CanisterSettings {
+            controllers: Some(vec![
+                global_super_admin_principal,
+                id(),
+                deployed_canister.root,
+            ]),
+            ..Default::default()
+        },
+    })
+    .await;
+
+    let _ = update_settings(UpdateSettingsArgument {
+        canister_id: deployed_canister.swap,
+        settings: CanisterSettings {
+            controllers: Some(vec![
+                global_super_admin_principal,
+                id(),
+                deployed_canister.root,
+                ic_nns_constants::ROOT_CANISTER_ID.into(),
+            ]),
+            ..Default::default()
+        },
+    })
+    .await;
+}

src/canister/individual_user_template/src/api/cdao/mod.rs

@@ -339,14 +339,14 @@ async fn deploy_cdao_sns(
     ));
     update_ctrls_futs.push(update_controllers(
         ledger,
-        vec![admin_canister, user_can, governance.0],
+        vec![admin_canister, user_can, root.0],
     ));
     update_ctrls_futs.push(update_controllers(
         swap,
         vec![
             admin_canister,
             user_can,
-            swap.0,
+            root.0,
             ic_nns_constants::ROOT_CANISTER_ID.into(),
         ],
     ));

src/lib/shared_utils/src/types/mod.rs

@@ -1,2 +1,3 @@
 pub mod canister_specific;
 pub mod creator_dao_stats;
+pub mod sns_canisters;

src/lib/shared_utils/src/types/sns_canisters/mod.rs

@@ -0,0 +1 @@
+pub mod swap;