Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sizing and spacing of engagement icons and game components #391

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Fix sizing and spacing of engagement icons and game components #391

wants to merge 13 commits into from

Conversation

veer-pratap-yral
Copy link
Contributor

@veer-pratap-yral veer-pratap-yral commented Sep 3, 2024 •
edited
Loading

fixes #370
fixed Icons on the right side shift position during the loading of game components in the latest commit.

rupansh-sekar-yral
rupansh-sekar-yral previously approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@rupansh-sekar-yral rupansh-sekar-yral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ask product to review the UI,
code changes look fine

@veer-pratap-yral
Copy link
Contributor Author

@harshitasrivastav28 please review.
i think theres a very small update needs to be done on this , which is alignment of right icons.

@harshita-srivastava-yral
Copy link
Contributor

This is not good to go until we fix the alignment issue. The issue mentions the problem of alignment still perists.

@veer-pratap-yral veer-pratap-yral self-assigned this Sep 13, 2024
@harshita-srivastava-yral
Copy link
Contributor

Not good to go as HON icons look misalignment @veer-asbytes

@harshita-srivastava-yral
Copy link
Contributor

  • The engagement icon spacing is fixed.
  • Icon component has been made independent of the game
  • HON icons are misplaced which require fix @veer-asbytes
    Not good to go!

@veer-pratap-yral veer-pratap-yral force-pushed the Hon-Game-ui-ux-fixes/fix-right-icons-and-spacing-game-components branch 2 times, most recently from 3105bd6 to 547e4c3 Compare September 20, 2024 08:02
@veer-pratap-yral veer-pratap-yral force-pushed the Hon-Game-ui-ux-fixes/fix-right-icons-and-spacing-game-components branch 2 times, most recently from d2309c6 to 73995c5 Compare September 20, 2024 11:03
@harshita-srivastava-yral
Copy link
Contributor

@veer-asbytes Unable to see HON game in the deployment link to verify the changes. Once fixed please share the link for me to verify

@harshita-srivastava-yral harshita-srivastava-yral removed their assignment Sep 20, 2024
@veer-pratap-yral veer-pratap-yral force-pushed the Hon-Game-ui-ux-fixes/fix-right-icons-and-spacing-game-components branch from a9bfdd2 to d2e508c Compare September 20, 2024 13:00
@veer-pratap-yral
Copy link
Contributor Author

@veer-asbytes Unable to see HON game in the deployment link to verify the changes. Once fixed please share the link for me to verify

okay ,

@veer-pratap-yral veer-pratap-yral force-pushed the Hon-Game-ui-ux-fixes/fix-right-icons-and-spacing-game-components branch from acefe46 to d2e508c Compare September 20, 2024 14:37
@harshita-srivastava-yral
Copy link
Contributor

Good to go from product POV @veer-asbytes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rupansh-sekar-yral rupansh-sekar-yral Awaiting requested review from rupansh-sekar-yral

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix sizing and spacing of engagement Icons on the right, spacing and placement of game components
4 participants
@veer-pratap-yral @harshita-srivastava-yral @rupansh-sekar-yral @Veercodeprog