feat: add delete account frontend #532
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tushar-saxena-yral
requested review from
komal-sai-yral and
joel-medicala-yral
tushar-saxena-yral
temporarily deployed
to
pr-532
GitHub Actions
Inactive
tushar-saxena-yral
requested review from
rupansh-sekar-yral
and removed request for
komal-sai-yral and
joel-medicala-yral
rupansh-sekar-yral
requested changes
Nov 25, 2024
ssr/src/page/account_help.rs
Outdated
| let show_confirm_perma_delete_modal = create_rw_signal(false); | ||
|
|
||
| view! { | ||
| <ShadowOverlay show=show_confirm_delete_modal> |
There was a problem hiding this comment.
move the delete modal to a separate component so the AccountHelp component is easier to read
There was a problem hiding this comment.
aye, on it
tushar-saxena-yral
temporarily deployed
to
pr-532
GitHub Actions
Inactive
tushar-saxena-yral
temporarily deployed
to
pr-532
GitHub Actions
Inactive
rupansh-sekar-yral
requested changes
Nov 25, 2024
ssr/src/page/account_help.rs
Outdated
| view! { | ||
| <ShadowOverlay show=show_confirm_delete_modal> | ||
| <ShadowOverlay show=show> | ||
| <div class="flex flex-col gap-4 p-6 mx-6 w-full lg:w-1/2 max-h-[65%] rounded-xl bg-neutral-900"> | ||
| <h2 class="text-white font-bold text-2xl text-center">Are you sure you want to delete your account?</h2> | ||
| <a class="bg-[#E2017B] text-white px-0 py-3 rounded-full text-center" href="/logout">Yes</a> |
There was a problem hiding this comment.
use pre-existing color classes instead of hardcoding
bg-primary-600
There was a problem hiding this comment.
understood
ssr/src/page/account_help.rs
Outdated
| #[component] | ||
| fn ConfirmPermaDeleteModal(#[prop(into)] show: RwSignal<bool>) -> impl IntoView { | ||
| view! { | ||
| <ShadowOverlay show=show> | ||
| <div class="flex flex-col gap-4 p-6 mx-6 w-full lg:w-1/2 max-h-[65%] rounded-xl bg-neutral-900"> | ||
| <h2 class="text-white font-bold text-2xl text-center">Do you want to permanently delete your account?</h2> | ||
| <button class="bg-[#E2017B] text-white px-0 py-3 rounded-full" on:click=move |_| { |
rupansh-sekar-yral
approved these changes
Nov 26, 2024
tushar-saxena-yral
had a problem deploying
to
pr-532
GitHub Actions
Failure
|
@tushar-saxena-yral this is ready to merge right? |
|
The frontend is ready, but the perma delete flow is not worked on at all. so i am not sure if it makes sense to merge it right now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes yral-dapp/hot-or-not-backend-canister#429