Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory parameter extension - Path Template #116

Merged
merged 16 commits into from
Mar 8, 2017

Conversation

kdybicz
Copy link
Collaborator

@kdybicz kdybicz commented Mar 1, 2017

  • Introducing output directory extension using Path Template
  • Splitting tests groups into separate ones
  • Upgrading ava dependency to 0.18.2
  • Updating configtest (in progress)
  • Updating README.md (in progress)

Copy link
Owner

@ysugimoto ysugimoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currenty I think it is better, thanks.

@kdybicz
Copy link
Collaborator Author

kdybicz commented Mar 7, 2017

It looks like we are ready for final review. Let me know if you have any comments.

@ysugimoto
Copy link
Owner

Looks good, let's merge this and close #114

@kdybicz
Copy link
Collaborator Author

kdybicz commented Mar 8, 2017

I will prepare for merging. As for #114 I would like to introduce it as alternative to directory and template, as third, even more advanced option. But I would like to do that later, so if you are ok, I would like to leave #114 open for now.

@ysugimoto
Copy link
Owner

It's OK.

@ysugimoto ysugimoto merged commit 4b0baf6 into master Mar 8, 2017
@kdybicz kdybicz deleted the directory-extension-path-template branch March 8, 2017 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants