Merge pull request #3246 from Lagertonne/feature/cumulus_nvue

Cumulus: Add nvue support
ytti · Sep 3, 2024 · 2ef5be1 · 2ef5be1
2 parents c38386b + 6e399d9
commit 2ef5be1
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
 - fortios: variable `fullconfig` to get the configuration with default values. Fixes: #3159 (@robertcheramy)
 - model for VMWare NSX DFW (@elmobp)
 - model for F5OS (@teunvink)
+- cumulus: Add possibility to use NVUE (@lagertonne)
 - model for garderos (@robertcheramy)
 - unit tests framework for models with ssh input (@robertcheramy)
 

diff --git a/docs/Model-Notes/Cumulus.md b/docs/Model-Notes/Cumulus.md
@@ -11,6 +11,9 @@ A variable has been added to enable users running Cumulus Linux > 3.4.0 to targe
 ## NCLU
 It is possible to switch to [NCLU](https://docs.nvidia.com/networking-ethernet-software/cumulus-linux-44/System-Configuration/Network-Command-Line-Utility-NCLU/) as a configuration collecting method, by setting `cumulus_use_nclu` to true
 
+## NVUE
+It is also possible to use [NVUE](https://docs.nvidia.com/networking-ethernet-software/knowledge-base/Setup-and-Getting-Started/NVUE-Cheat-Sheet/) as a configuration collecting method, by setting `cumulus_use_nvue` to true.
+
 ### Example usage
 
 ```yaml
@@ -43,4 +46,6 @@ The default value for `cumulus_routing_daemon` is `quagga` so existing installat
 
 The default value for `cumulus_use_nclu` is `false`, in case NCLU is not installed.
 
+The default value for `cumulus_use_nvue` is `false`, in case NVUE is not installed.
+
 Back to [Model-Notes](README.md)
diff --git a/lib/oxidized/model/cumulus.rb b/lib/oxidized/model/cumulus.rb
@@ -21,9 +21,12 @@ def add_comment(comment)
   # show the persistent configuration
   pre do
     use_nclu = vars(:cumulus_use_nclu) || false
+    use_nvue = vars(:cumulus_use_nvue) || false
 
     if use_nclu
       cfg = cmd 'net show configuration commands'
+    elsif use_nvue
+      cfg = cmd 'nv config show --color off'
     else
       # Set FRR or Quagga in config
       routing_daemon = vars(:cumulus_routing_daemon) ? vars(:cumulus_routing_daemon).downcase : 'quagga'