Added handling of more ios-xe and nxos secrets #3320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmunities and radius keys
robertcheramy
added a commit
that referenced
this pull request
Nov 15, 2024
command set for creating a YAML simulation file for PR #3320
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ios.rb changes:
IS-IS domain passwords hidden (with or without extra options)
IPSEC PSKs hidden
For IPSEC PSKs the configuration lines have the same issues as here:
oxidized/lib/oxidized/model/ios.rb
Line 29 in b1be800
Which means we need to hide everyhing after the first command, there is no part of the command that lets us know that the next word is the actual key.
nxos.rb changes:
vrf-aware SNMP communities hidden
radius keys hidden (currently only global keys are hidden, this will hide both global and host-specific keys)