Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizing echarts with wasm renderer #28

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

koopa1338
Copy link
Contributor

I was not able to resize charts properly after rendering with the wasm renderer. This PR just generates binding to the resize function from echarts and adds types and enums for the resizing options. I had to return the Echarts type from the init function to give access to the initialized chart instance, which makes the api also for future bindings more flexible.

Copy link
Owner

@yuankunzhang yuankunzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuankunzhang yuankunzhang merged commit 21020cb into yuankunzhang:main Nov 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants