Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add symbol callback #91

Merged
merged 4 commits into from
Oct 7, 2024
Merged

add symbol callback #91

merged 4 commits into from
Oct 7, 2024

Conversation

yg0x01
Copy link
Contributor

@yg0x01 yg0x01 commented Oct 6, 2024

I would like to propose a PR that adds support for setting the symbol using a callback function, as described in the ECharts documentation regarding symbol. Currently, the Symbol structure in the code does not support this method. Therefore, I have introduced a Callback enum to accommodate this functionality.

@LukaOber
Copy link
Collaborator

LukaOber commented Oct 6, 2024

Can you provide an example of a callback function?

@yg0x01
Copy link
Contributor Author

yg0x01 commented Oct 7, 2024

Can you provide an example of a callback function?

Certainly. I have added an example to the line chart gallery (different_symbols.rs) to demonstrate the functionality of the symbol callback.

image

@LukaOber
Copy link
Collaborator

LukaOber commented Oct 7, 2024

Thank you very much. LGTM

@LukaOber LukaOber merged commit 8def462 into yuankunzhang:main Oct 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants