This repository has been archived by the owner on May 25, 2018. It is now read-only.
Add events to accordion when panel opens and closes. #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would be nice if an accordion has knowledge when one of its panels opens or closes and which panel it is. My usecase is that I want to send an AJAX request when a panel get closed. With the following implementation the open and closed event on the panel will pushed to the accordion component if the panel is within an accordion. The closed event on the accordion component will be fired when an open panel got closed by opening another panel.
Add the possibility to add a panel footer. Its a first draft and I am not sure atm if the footer should be hidden when the panel gets closed or not. Options are: - Footer is always there - Footer got hidden, when Panel gets closed - Its configurable
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: For v2 branch.
It would be nice if an accordion has knowledge when one of its panels opens
or closes and which panel it is.
My usecase is that I want to send an AJAX request when a panel get closed.
With the following implementation the open and closed event on the panel will pushed to
the accordion component if the panel is within an accordion.
The closed event on the accordion component will be fired when an open panel got closed
by opening another panel.