Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): privilege type forward compat (#14501) #25

Open
wants to merge 1 commit into
base: 1.2.307-hotfix-20240430
Choose a base branch
from

Conversation

TCeason
Copy link

@TCeason TCeason commented Aug 26, 2024

  • fix(query): privilege type forward compat
  1. add ci test forward compat test(now only test rbac)
  2. UserPrivilegeType and ShareGrantObjectPrivilege deserialize use from_bits_truncate
  • run_test contain forward and backward

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

* fix(query): privilege type forward compat

1. add ci test forward compat test(now only test rbac)
2. UserPrivilegeType and ShareGrantObjectPrivilege deserialize use from_bits_truncate

* run_test contain forward and backward
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant