Address deprecation warnings

yuki24 · Jan 4, 2024 · 7cec4cb · 7cec4cb
1 parent 93a1e0f
commit 7cec4cb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -136,7 +136,7 @@ jobs:
         with:
           ruby-version: 3.3
           bundler-cache: true
-      - run: bundle exec rake || echo "Rails edge test is done."
+      - run: bundle exec rake
 
   ruby_edge:
     needs:

diff --git a/lib/rambulance/test_helper.rb b/lib/rambulance/test_helper.rb
@@ -28,7 +28,12 @@ def with_exceptions_app(enabled: true)
       org_show_exceptions          = Rails.application.env_config['action_dispatch.show_exceptions']
 
       Rails.application.env_config['action_dispatch.show_detailed_exceptions'] = !enabled
-      Rails.application.env_config['action_dispatch.show_exceptions']          = enabled
+
+      if ActionDispatch::ExceptionWrapper.instance_methods.include?(:show?)
+        Rails.application.env_config['action_dispatch.show_exceptions'] = enabled ? :all : :none
+      else
+        Rails.application.env_config['action_dispatch.show_exceptions'] = enabled
+      end
 
       yield
     ensure
@@ -37,4 +42,3 @@ def with_exceptions_app(enabled: true)
     end
   end
 end
-