Add the ability to precompile error pages on asset precompile #70
+160
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Often times dynamically generating error pages is risky, and it’s not always necessary to do that when the error page generation does not rely on dynamic logic. What’s more important though is that is that it’s often painful to re-use the same CSS assets with the main app and the static pages. We should be able to achieve this by generating error pages at the time of asset pre-completion, rather than doing so at runtime.
Todos
rambulance:precompileDrop support for Rails 4.2? It doesn’t have support for the controller rendererskipped test for this one for now.static_error_pages = true/false