Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#82 introduce melos and dvmx #101

Merged
merged 13 commits into from
Feb 13, 2024

Conversation

Yamasaki-pan961
Copy link
Contributor

@Yamasaki-pan961 Yamasaki-pan961 commented Feb 13, 2024

Issue

Overview (Required)

  • Introduce dvmx
  • Introduce melos
  • Add GET_STARTED.md
  • Standardize dependency version
  • Refactor and Update launch.json

Links

In some cases, melos commands and scripts do not work because melos and Version Manage are not compatible.

Copy link
Contributor

Ready for review 🚀

@Yamasaki-pan961 Yamasaki-pan961 changed the base branch from main to release/2.0.0 February 13, 2024 10:37
Copy link
Member

@blendthink blendthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yamasaki-pan961
Thank you!

Could you please rewrite the GitHub Actions workflow using the following GitHub Action?
https://github.com/blendfactory/dvm-config-action

```bash
dvm use
```
1. Run the command `dvm dart --version` to check the version.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits-badge
typo

Suggested change
1. Run the command `dvm dart --version` to check the version.
3. Run the command `dvm dart --version` to check the version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed: 8100782

"type": "dart",
"program": "bin/check_lint_rules_identity.dart",
"args": [
"input_example/no_diff_version_paths.txt",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good-badge
😍

@Yamasaki-pan961
Copy link
Contributor Author

@blendthink

Could you please rewrite the GitHub Actions workflow using the following GitHub Action?
https://github.com/blendfactory/dvm-config-action

Changed to use it!!
9a00902

Copy link
Member

@blendthink blendthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@Yamasaki-pan961 Yamasaki-pan961 merged commit 4ccdc5f into release/2.0.0 Feb 13, 2024
@Yamasaki-pan961 Yamasaki-pan961 deleted the feature/#82_introduce-melos-and-dvmx branch February 13, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve]: Standardize Dart and Dependency Versions for CLI Apps Under 'tools'
2 participants