feat: add support for ARW, DNG, CR2 raw #140
Conversation
|
@yurijmikhalevich, could you please review the changes and suggest your valuable opinion? |
yurijmikhalevich
changed the title
There was a problem hiding this comment.
This is an amazing start 🙌 Thank you. Can you please add a test or two that includes all of the newly added image formats?
When adding test images, can you please pick or create RAW files that weigh as little as possible to keep the repo size small?
There was a problem hiding this comment.
I have downloaded the raw images from internet that have relatively larger file sizes (about 10 to 40 MB). I also searched conversion tools and tried to convert using Python libraries. But it didn't work.
Adding these larger images could increase the tool size. What is your opinion regarding this sized image upload to the test folder? @yurijmikhalevich
There was a problem hiding this comment.
@abidkhan484, I think adding 3 10Mb images to the repository can be ok. We aren't bundling them in the distributions anyway.
But, if we can create 3 small 100px * 100px RAW images, it would be much better.
Also, when adding images, we should be mindful of their license. All of the images in the rclip test dir are the images I took myself 😄
There was a problem hiding this comment.
@yurijmikhalevich, I have tried to resize or convert images. But I failed. So, It's difficult for me to add different raw photos. But I can download some raw images from the internet those sizes on average 40MB. Need your suggestion badly.
There was a problem hiding this comment.
@abidkhan484, let me see what I can do.
There was a problem hiding this comment.
@abidkhan484, I am going to cleanup and merge your branch, and then will add tests in a separate PR.
I can't add it in this PR because GitHub and git-lfs don't let me push large images to your branch (-:
There was a problem hiding this comment.
@abidkhan484, another important thing to do in this PR was to ensure that the --preview works for the RAW images. Check out this diff for implementation: 46f2fc8.
There was a problem hiding this comment.
Hm. Also, it doesn't actually support "DNG" files created by Lightroom. This is why tests are important 💭
There was a problem hiding this comment.
@abidkhan484, merged! 🙌 Congrats with your first contribution to rclip and thank you for the help 🔥
abidkhan484
force-pushed
the
support-arw-image-format
branch
from
d315908
to
f5a569c
Compare
|
@all-contributors please add @abidkhan484 for code |
|
I've put up a pull request to add @abidkhan484! 🎉 |
Adds @abidkhan484 as a contributor for code. This was requested by yurijmikhalevich [in this comment](#140 (comment)) --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
This pull request for the issue #15 will introduce:
The other raw format should work by adding the extension in the IMAGE_REGEX constant but the below formats are not yet tested.