expand disconnect reasons

[NotAFile]

add the new disconnect reasons

[BR-]

Should we use piqueserver/aosprotocol#15 instead of adding more fixed strings?

[NotAFile]

There's a few things with that:

• Those messages aren't localized to the local language of the user
• There are already installs out there using these new error codes. If we don't add them, they will show up as "Unknown Reasons" instead.
• It really doesn't hurt to have more reasons here. It's a simple change. Adding that proposal is good but takes more code, so I haven't done it for now.

[yvt]

The word “you” might be inappropriate here because it’s not necessarily “you” who has the connections (e.g., other people behind a NAT).

[NotAFile]

I had similar concerns but I was unsure how to phrase it instead. "Your IP" might be correct at the moment, but:

• people, in general, are not that familiar with where their IP comes from, especially in larger networks and with the increased prevalence of CGNATs
• this is a technical detail and might change in the future

Perhaps "Your location" or "Your network" is a good solution?

[feikname]

Seems like "Your network's public address has too many connections to this server" would be the best solution, even though some users may not understand it, I believe it's best to deliver the most accurate message.

Maybe a text below with additional info could be added including the common reasons this might be happening.