Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding SvelteKit Auth/Auth.js to the main stack #30

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

L-Mario564
Copy link
Contributor

@L-Mario564 L-Mario564 commented Dec 21, 2022

Implementing Vercel's official auth solution for SvelteKit.

Checklist

  • Auth.js (as a standalone package)
  • Auth.js + Prisma
  • Auth.js + Prisma + tRPC
  • Update README with information about this package

@zach-hopkins
Copy link
Owner

zach-hopkins commented Dec 28, 2022

Great thanks on all this @L-Mario564! Much appreciated. Looks good to me on a glance, i'll give it a thorough review later. What's left on the tRPC + Auth + Prisma front?

@L-Mario564
Copy link
Contributor Author

With tRPC, I seem to have issues, iirc it's related to types. Other than that I have to update a few things since a few breaking changes were introduced in the auth package (as well as waiting for a few issues to be solved for it)

Comment on lines +15 to +24
provider String
providerAccountId String
refresh_token String?
access_token String?
expires_in Int?
token_type String?
scope String?
id_token String?
session_state String?
user User @relation(fields: [userId], references: [id], onDelete: Cascade)
Copy link

@m9p909 m9p909 Feb 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the create-t3-app starter has commented out db.text fields. These comments will save the users a lot of headache when they see the string too long SQL error.

    providerAccountId String
    refresh_token     String? // @db.Text
    access_token      String? // @db.Text
    expires_at        Int?
    token_type        String?
    scope             String?
    id_token          String? // @db.Text

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants